Re: svn commit: r1131383 - in /subversion/trunk/subversion: include/private/svn_magic.h libsvn_client/add.c libsvn_client/client.h libsvn_client/commit.c libsvn_subr/io.c libsvn_subr/magic.c

Stefan Sperling <stsp_at_elego.de> writes:

> On Mon, Jun 06, 2011 at 09:08:11AM +0100, Philip Martin wrote:
>> Stefan Sperling <stsp_at_elego.de> writes:
>>
>> > If an empty file gets a property that svn considers binary the tests
>> > start failing all over the place.
>>
>> Perhaps the testsuite should use its own magic database?
>
> Well, that would just cover up symptoms in the test suite.
>
> The problem is that some operations behave differently.
> For instance, running diffs against empty files stops working.
> If people use empty files to try things out in Subversion,
> they won't expect it to complain, by default(!), when certain
> operations are run on the these files.
>
> So setting a binary mime-type on empty files by default is really not
> a great idea. Even from the end-user perspective, not just in the test
> suite. If people set it manually then they can deal with the consequences.

The user can configure things like auto-props, external diff, etc. in
such a way that the testsuite would fail. We allow these configurations
because the user may have legitimate reasons for wanting Subversion to
behave this way. The testsuite doesn't use the user or system values,
it uses its own values that are known to work.

Why is the magic database different? Perhaps there are users that want
empty files to have a particular mime type automatically?

-- 
Philip