[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] possible improvement to svn log with "forward" revision range (issue 3830)

From: Dirk Thomas <websvn_at_dirk-thomas.net>
Date: Thu, 02 Jun 2011 19:06:52 +0200

>> Could someone of the devs please take a closer look?
>> I am willing to improve the patch based on concrete suggestions.
> [...]
> Sure thing. I can see where you're going with the patch. I haven't taken
> the time to fully consider the appropriate, so consider the following a
> syntactical patch review only.

thank you for your feedback.
I have updated the patch of "libsvn_client/log.c" according to your suggestions.

> Finally, patches are best sent to the mailing list with a "[PATCH] "

Additionally i have added a test to "tests/cmdline/log_tests.py" to check for desired results.
The newly added test will pass when the above enhancement has been applied (other tests also pass).

The combined patch is attached.

> Subject: line prefix *and* a valid log message.

The log message might be:
Fix issue #3830: support "forward" logs for revision ranges where the target has been removed before end-of-range.

    * subversion/libsvn_client/log.c
      (svn_client_log5): replace end of revision range with revision before item is deleted if necessary.

    * subversion/tests/cmdline/log_tests.py
      (forward_log): added test for "forward" logs where target has been removed before end-of-range.

    Patch by: Dirk Thomas <websvn_at_dirk-thomas.net>

If the modifications need further polishing please just drop me a note.


  • text/x-patch attachment: stored
Received on 2011-06-02 19:07:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.