Re: svn commit: r1129980 - /subversion/trunk/notes/knobs

On Jun 1, 2011 10:09 AM, "Stefan Sperling" <stsp_at_elego.de> wrote:
>
> On Wed, Jun 01, 2011 at 09:57:24AM -0400, Greg Stein wrote:
> > I had a define in workqueue.c that somebody recently prefixed with SVN_.
>
> That was me.
>
> > I never intended it to be part of *any* API. just a little helper for us
devs.
> > Yet now it shows up in knobs, and is an "official API"?!?
> >
> > Seems we may want to reconsider how stuff magically becomes a "knob".
>
> I don't really see the point of documenting this define in notes/knobs
> either. Should I move this back to a file-private define that isn't
> documented in knobs?

No need to rename it (either name would be valid in that file), but yanking
it from knobs makes sense to me.

Cheers,
-g
Received on 2011-06-01 16:23:24 CEST