[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1129957 - in /subversion/trunk: notes/knobs subversion/libsvn_diff/diff_file.c

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Wed, 01 Jun 2011 15:10:53 +0100

On Wed, 2011-06-01 at 01:39 +0200, Johan Corveleyn wrote:
> On Wed, Jun 1, 2011 at 1:22 AM, Stefan Sperling <stsp_at_elego.de> wrote:
> > On Wed, Jun 01, 2011 at 01:15:56AM +0200, Johan Corveleyn wrote:
> >> [[[
> >> The usual namespace rules apply: only names that begin with "SVN_"
> >> and don't contain double underscores are considered part of the public
> >> API. Everything else is not officially supported.
> >> ]]]
> >>
> >> Thinking: "I don't think this should be part of the public API", so I
> >> can just dispense with the "SVN_" prefix.
> >
> > In this case I would advocate for SVN__DISABLE_PREFIX_SUFFIX_SCANNING :)
> > You're right that it doesn't need to be part of the public API.
> I went for SVN_DISABLE_PREFIX_SUFFIX_SCANNING in the end (r1129965).
> Who knows, maybe it can prove useful someday, if some special build
> needs to disable this f.i. because it has problems with the seeking
> around of the prefix/suffix scanning (jumping to the end of the file,
> then jumping to the start again) or something ...

I think the implication that these #defines are considered part of the
public API is not true.

This one's purpose is definitely private (debugging/testing/optimising);
there's no point in speculating that it might turn out to be useful.

- Julian
Received on 2011-06-01 16:11:29 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.