Re: [PATCH] Speed-up of libsvn_diff using token counts

On Mon, May 30, 2011 at 12:26 PM, Stefan Sperling <stsp_at_elego.de> wrote:
> On Mon, May 30, 2011 at 08:25:38AM +0200, Markus Schaber wrote:
>> Hi, Morten,
>>
>> > Von: Morten Kloster [mailto:morklo_at_gmail.com]
>>
>> > I haven't changed the index/count types yet. What's the right type to use
>> > to get signed 32 bit on 32-bit machines and signed 64 bit on 64-bit
>> > machines?
>>
>> You should use intptr_t from stdint.h, I'd guess.
>
> Not possible, unfortunately.
> We don't use any C99 constructs in Subversion because some compilers
> (especially on Windows) don't support them.
>

Well, it's just a typedef now, so it's no biggie if and when we decide
to change it.

Johan, any progress on reviewing the code on your part? Things are
a bit simpler now with the idx patch in: Since that patch settled the
file (re)order issue, this patch now produces fully identical results to
HEAD.

Morten
Received on 2011-05-30 20:51:30 CEST