[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Windows build, nonexistent functions

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sat, 28 May 2011 19:39:08 +0200

On 28.05.2011 19:33, Daniel Shahaf wrote:
> Stefan Küng wrote on Sat, May 28, 2011 at 19:05:34 +0200:
>> On 28.05.2011 19:03, Daniel Shahaf wrote:
>>> Stefan Küng wrote on Sat, May 28, 2011 at 15:43:58 +0200:
>>>> I think having such functions mentioned in the header but not
>>>> implemented is not good.
>>> Why are you telling us that? You have commit access.
>> I don't want to break something. Maybe those will get implemented soon?
> Fair enough.
> However, we don't have a practice of keeping declarations without
> corresponding definitions. If that is indeed the case (as opposed to
> definitions which are conditional on preprocessor macros that the
> declaration isn't conditional upon), IMO go ahead and drop the
> declarations.

I did a grep search for those functions, and the only files they showed
up were the headers, no other files contained those function names. So
it's not because of preprocessor conditionals.

I'll wait until tomorrow. If there are no objections until then, I'll
commit a change which removes those.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
Received on 2011-05-28 19:39:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.