Re: [PATCH] Speed-up of libsvn_diff using token counts

Morten Kloster wrote:
> On Fri, May 27, 2011 at 4:55 PM, Julian Foad <julian.foad_at_wandisco.com> wrote:
> > Morten Kloster wrote:
> >> I haven't changed the index/count types yet. What's the right type
> >> to use to get signed 32 bit on 32-bit machines and signed 64 bit
> >> on 64-bit machines?
> >
> > "int"?
>
> Is int guaranteed to correspond to (or be larger than) single-process
> addressable space?

No. Some 64-bit platforms use 32-bit ints by default and 64-bit
pointers.

But do you really need to guarantee that svn's text-diff will cope with
more than 2 billion lines on such a system? Personally I don't think
so. If you think that is important, you can use "long int".

- Julian
Received on 2011-05-27 19:57:41 CEST