[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Speed-up of libsvn_diff using token counts

From: Morten Kloster <morklo_at_gmail.com>
Date: Thu, 26 May 2011 23:04:43 +0200

On Thu, May 26, 2011 at 6:32 PM, Mark Phippard <markphip_at_gmail.com> wrote:
> On Thu, May 26, 2011 at 11:13 AM, Mark Phippard <markphip_at_gmail.com> wrote:
>> I applied your patch on OSX and figured I would at least run the tests
>> for you.  Builds go OK, but the one of the tests fail and two other
>> tests crash your patch applied.  The crashes look the same in both
>> cases.
>> Note, I have not run tests recently on this box, so I am not 100%
>> certain the tests crash from your patch, but given that it is in diff
>> code, it seems likely.
> Just to followup, I reverted your patch and re-ran the tests and did
> not get any failures.
> --
> Thanks
> Mark Phippard
> http://markphip.blogspot.com/

I guess there's a bug in diff3, then (and probably in diff4 as well);
I've tested basic diff quite extensively by now. I'll look into it.

Thanks for doing the tests! :-)

Received on 2011-05-26 23:05:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.