Re: [PATCH] Speed-up of libsvn_diff using token counts

On Thu, May 26, 2011 at 6:32 PM, Mark Phippard <markphip_at_gmail.com> wrote:
> On Thu, May 26, 2011 at 11:13 AM, Mark Phippard <markphip_at_gmail.com> wrote:
>> I applied your patch on OSX and figured I would at least run the tests
>> for you.  Builds go OK, but the one of the tests fail and two other
>> tests crash your patch applied.  The crashes look the same in both
>> cases.
>>
>> Note, I have not run tests recently on this box, so I am not 100%
>> certain the tests crash from your patch, but given that it is in diff
>> code, it seems likely.
>
> Just to followup, I reverted your patch and re-ran the tests and did
> not get any failures.
>
> --
> Thanks
>
> Mark Phippard
> http://markphip.blogspot.com/
>

I guess there's a bug in diff3, then (and probably in diff4 as well);
I've tested basic diff quite extensively by now. I'll look into it.

Thanks for doing the tests! :-)

Morten
Received on 2011-05-26 23:05:20 CEST