[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1127862 - /subversion/trunk/subversion/tests/libsvn_subr/dirent_uri-test.c

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 26 May 2011 13:33:26 +0200

On Thu, May 26, 2011 at 10:53:20AM -0000, rhuijben_at_apache.org wrote:
> Author: rhuijben
> Date: Thu May 26 10:53:20 2011
> New Revision: 1127862
>
> URL: http://svn.apache.org/viewvc?rev=1127862&view=rev
> Log:
> * subversion/tests/libsvn_subr/dirent_uri-test.c
> (test_funcs): Remove WIMP from test_dirent_get_absolute_from_lc_drive.
> It should pass for 1.7, but you need a recent apr version to make it pass
> if it doesn't pass for you.

Maybe make this XFAIL depending on APR_VERSION_AT_LEAST()?
That would also be more explicit than 'recent'.

>
> Modified:
> subversion/trunk/subversion/tests/libsvn_subr/dirent_uri-test.c
>
> Modified: subversion/trunk/subversion/tests/libsvn_subr/dirent_uri-test.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_subr/dirent_uri-test.c?rev=1127862&r1=1127861&r2=1127862&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/tests/libsvn_subr/dirent_uri-test.c (original)
> +++ subversion/trunk/subversion/tests/libsvn_subr/dirent_uri-test.c Thu May 26 10:53:20 2011
> @@ -2917,9 +2917,8 @@ struct svn_test_descriptor_t test_funcs[
> SVN_TEST_PASS2(test_dirent_get_absolute,
> "test svn_dirent_get_absolute"),
> #ifdef WIN32
> - SVN_TEST_WIMP(test_dirent_get_absolute_from_lc_drive,
> - "test svn_dirent_get_absolute with lc drive",
> - "Requires patch from apr-trunk"),
> + SVN_TEST_PASS2(test_dirent_get_absolute_from_lc_drive,
> + "test svn_dirent_get_absolute (needs recent apr)"),
> #endif
> SVN_TEST_PASS2(test_dirent_condense_targets,
> "test svn_dirent_condense_targets"),
>
Received on 2011-05-26 13:34:02 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.