Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

Noorul Islam K M <noorul_at_collab.net> writes:

> Philip Martin <philip.martin_at_wandisco.com> writes:
>
>> Noorul Islam K M <noorul_at_collab.net> writes:
>>
>>> Index: subversion/libsvn_client/export.c
>>> ===================================================================
>>> --- subversion/libsvn_client/export.c (revision 1071880)
>>> +++ subversion/libsvn_client/export.c (working copy)
>>> @@ -524,7 +524,26 @@
>>> }
>>> else if (from_kind == svn_node_file)
>>> {
>>> + svn_node_kind_t kind;
>>> + svn_error_t *err;
>>> +
>>> SVN_ERR(append_basename_if_dir(&to_abspath, from_abspath, FALSE, pool));
>>> + svn_error_clear(svn_io_check_path(to_abspath, &kind, pool));
>>> +
>>> + if ((kind == svn_node_file) && ! force)
>>> + {
>>> + return svn_error_createf(SVN_ERR_FS_ALREADY_EXISTS, NULL,
>>> + _("Destination file '%s' exists, "
>>> + "and will not be overwritten unless "
>>> + "forced"),
>>> + svn_dirent_local_style(to_abspath, pool));
>>
>> That's the wrong error, SVN_ERR_FS_ is for the Subversion filesystem in
>> the repository.
>>
>
> I could see usage of the same at several places in libsvn_client.

It's still the wrong error to use here. The client layer might use it
to indicate that some path exists in the repository, but it's wrong to
use it to indicate that something exists on the local disk.

-- 
Philip