[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1126481 - /subversion/trunk/subversion/libsvn_subr/svn_base64.c

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 23 May 2011 09:31:59 -0400

On Mon, May 23, 2011 at 09:29, Hyrum K Wright <hyrum_at_hyrumwright.org> wrote:
> On Mon, May 23, 2011 at 6:16 AM, Greg Stein <gstein_at_gmail.com> wrote:
>>
>> On Mon, May 23, 2011 at 09:11,  <hwright_at_apache.org> wrote:
>> > Author: hwright
>> > Date: Mon May 23 13:11:10 2011
>> > New Revision: 1126481
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1126481&view=rev
>> > Log:
>> > Remove some integer size mismatch warnings by using size_t in places
>> > where
>> > we calculate pointer differences.
>>
>> Strictly speaking, it is best to use apr_size_t for those old
>> platforms where size_t is not available.
>>
>> That said, I doubt we're running on them nowadays...
>
> This came up in IRC just now, and we did the following on the 1.6.x branch:
>   $ find . -name '*.c' | xargs grep -w 'size_t' | wc -l
>        219
>   $
> It appears we've been releasing code with size_t for quite some time, and we
> haven't heard any complains, so I think we're safe.  :)

"Strictly speaking" :-)

(and its also why pocore doesn't go down that nonsense road...)

Cheers,
-g
Received on 2011-05-23 15:32:28 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.