Re: svn commit: r1125455 - in /subversion/trunk/subversion: libsvn_wc/upgrade.c libsvn_wc/wc.h libsvn_wc/wc_db_pristine.c tests/cmdline/svntest/wc.py

On May 23, 2011 8:10 AM, "Julian Foad" <julian.foad_at_wandisco.com> wrote:
>...
> > > + /* The old pristine file name was 40 hex digits. */
> > > + if (finfo->filetype == APR_REG && strlen(path) == 40)
> >
> > Because you have abspath values, this strlen() condition can never be
true.
>
> ... I added this line, and aargh, you're right. I only tested the
> negative condition: after introducing this check, it no longer
> doubled-renamed the already-renamed files. But didn't test that it
> still works.
>
> Thanks for the _abspath and #define suggestions. Will do.

Thought it was something like that. The "innocuous change before commit" ...
that isn't :-)

Cheers,
-g
Received on 2011-05-23 14:32:29 CEST