Re: [PATCH] - Remove unneeded code from svnadmin

On Mon, May 23, 2011 at 01:08:28PM +0530, Prabhu Gnana Sundar wrote:
> Hi all,
>
> I have attached my recent patch along with this mail. Please
> share your views.
>
>

Can you provide a log message, too?

> Index: subversion/svnadmin/main.c
> ===================================================================
> --- subversion/svnadmin/main.c (revision 1126350)
> +++ subversion/svnadmin/main.c (working copy)
> @@ -585,7 +585,6 @@
> {
> struct svnadmin_opt_state *opt_state = baton;
> svn_repos_t *repos;
> - apr_hash_t *config;
> apr_hash_t *fs_config = apr_hash_make(pool);
>
> /* Expect no more arguments. */
> @@ -624,12 +623,9 @@
> APR_HASH_KEY_STRING,
> "1");
>
> - SVN_ERR(svn_config_get_config(&config, opt_state->config_dir, pool));
> - SVN_ERR(svn_cmdline__apply_config_options(config, opt_state->config_options,
> - "svnadmin: ", "--config-option"));
> SVN_ERR(svn_repos_create(&repos, opt_state->repository_path,
> NULL, NULL,
> - config, fs_config, pool));
> + NULL, fs_config, pool));

We could wrap the above two lines into a single line.
So that we have just one line reading:

                            NULL, NULL, NULL, fs_config_pool));

Looks good to me, thanks!

> svn_fs_set_warning_func(svn_repos_fs(repos), warning_func, NULL);
> return SVN_NO_ERROR;
> }
Received on 2011-05-23 10:33:40 CEST