On Fri, May 20, 2011 at 12:58:11PM -0400, Mark Phippard wrote:
> Log message and patch attached.
> svnadmin create accepts the --config-dir option but no longer uses it
> for anything. I do not believe we can remove the option from the UI,
> but we can remove the code that get the configuration. The reason is
> that I have observed a couple of odd scenarios where this code causes
> 1) The process running svnadmin does not have read authority to
> $HOME/.subversion For example, here is an example from a mailing
> 2) Have observed similar problem on Windows when the process is
> running and it could not determine the home folder. Never figured out
> the root cause of this problem, as normally this does work OK on
> The workaround people have used is to specify --config-dir and point
> it at ' ' or some random folder they can read. But if we just removed
> this code they would not get a problem in the first place.
> Ran make check and manually tested the binary.
> Mark Phippard
> Remove unneeded code that can cause errors.
> svnadmin create accepts the --config-dir option but no longer use it.
> Have seen errors when process cannot determine HOME or read the $HOME/.subversion
> * subversion/svnadmin/main.c
> (subcommand_create): Remove code to get and apply the config.
> Index: subversion/svnadmin/main.c
> --- subversion/svnadmin/main.c (revision 1125450)
> +++ subversion/svnadmin/main.c (working copy)
> @@ -616,9 +616,6 @@
> - SVN_ERR(svn_config_get_config(&config, opt_state->config_dir, pool));
> - SVN_ERR(svn_cmdline__apply_config_options(config, opt_state->config_options,
> - "svnadmin: ", "--config-option"));
> SVN_ERR(svn_repos_create(&repos, opt_state->repository_path,
> NULL, NULL,
> config, fs_config, pool));
I think we should remove the 'config' variable altogether and pass NULL
instead. This is allowed as per svn_repos_create()'s docstring.
Received on 2011-05-21 13:05:33 CEST