On Wed, May 18, 2011 at 07:31:54PM +0200, Morten Kloster wrote:
> >
> > I'm attaching a version of the patch re-generated with -x-pw.
> >
> > [[[
> > Index: subversion/libsvn_diff/diff.c
> > ===================================================================
> > --- subversion/libsvn_diff/diff.c (revision 1104340)
> > +++ subversion/libsvn_diff/diff.c (working copy)
> > @@ -105,6 +105,10 @@ svn_diff_diff_2(svn_diff_t **diff,
> > {
> > svn_diff__tree_t *tree;
> > svn_diff__position_t *position_list[2];
> > + apr_uint32_t num_tokens;
> > + apr_uint32_t token_index;
> > + svn_diff__position_t *current;
> > + apr_uint32_t *token_counts[2];
The indentation above looks wrong and in some other places, too.
Morten, your patch is very interesting. But I don't want to review it
as posted. Can you please provide a fresh patch that includes only
your functional changes and uses correct code formatting as per our
coding guidelines? See the community guide at
http://subversion.apache.org/docs/community-guide/conventions.html
This would speed up processing your patch a lot. Any overhead spent
separating functional from non-functional changes and checking the
coding style is time better spent by the patch submitter than the
patch reviewers. It's a question of one person investing the time
vs. N people investing the time. If only one person spends this time
the community as a whole wins time. Thank you :)
Received on 2011-05-19 11:39:53 CEST