[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1103749 - /subversion/trunk/subversion/libsvn_wc/wc_db_wcroot.c

From: Branko ─îibej <brane_at_e-reka.si>
Date: Wed, 18 May 2011 21:25:11 +0200

On 17.05.2011 12:37, Stefan Fuhrmann wrote:
> On 17.05.2011 10:11, Greg Stein wrote:
>> On May 16, 2011 10:29 AM,<stefan2_at_apache.org> wrote:
>>> Author: stefan2
>>> Date: Mon May 16 14:28:45 2011
>>> New Revision: 1103749
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1103749&view=rev
>>> Log:
>>> SVN status will try to read the .format file for every folder in
>>> the working copy. That is very expensive, so do a stat call
>>> to check whether the .format file exists - which it won't for
>>> wc-ng w/cs.
>> Is this true for both Windows and unix-ish?
> AFAICT, this is true for both Windows and Unix.
> Even if a failed file_open is equivalent to a stat,
> we would still create a locale-dependent svn_error_t
> object and that is expensive (at least not for free).

Wait -- creating an svn_error_t is more expensive than the extra stat?

-- Brane
Received on 2011-05-18 21:25:45 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.