[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1104610 - in /subversion/trunk/subversion/libsvn_wc: props.c wc_db.c wc_db.h

From: Bert Huijben <bert_at_qqmail.nl>
Date: Wed, 18 May 2011 11:11:30 +0200

> -----Original Message-----
> From: Greg Stein [mailto:gstein_at_gmail.com]
> Sent: woensdag 18 mei 2011 11:07
> To: dev_at_subversion.apache.org
> Cc: Hyrum K Wright
> Subject: RE: svn commit: r1104610 - in
> /subversion/trunk/subversion/libsvn_wc: props.c wc_db.c wc_db.h
> No, we said if somebody breaks the build, then it can be reverted.
> Breaking the tests does not qualify. You were out of line. I just got
> telling off people in Lucene-land for this. I also said that if it were up
> to me, I would warn somebody about the anti social behavior once, and
> remove
> their commit privs on the second time. It is THAT much of a problem in the
> community dynamics.
> Don't do that again.

Does breaking all the property handling code qualify?

That was what happened...

Not just a few random tests. There were dozens of tests broken, but the test
suite itself was broken in a different way that didn't catch it.

All the single property accesses were routed through the new depthy code,
that was fundamentally flawed until I fixed it. (Which was impossible to
find without reverting).

Received on 2011-05-18 11:12:51 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.