[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: enhancements for error reporting

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 18 May 2011 10:13:07 +0200

Bert Huijben wrote on Wed, May 18, 2011 at 00:53:48 -0700:
> One obvious case is that libsvn_client sometimes suggests that you
> should do a 'svn something', which is only possible if you use svn.
>

I can't find any of these; you might have meant libsvn_wc?

subversion/libsvn_client% grep \'svn *c | grep -v \/\*
zsh: exit 1 grep -v \/\*

> +1 on better + documented error codes in similar cases, to fix this.
>
> Bert Huijben (Cell phone) From: Daniel Shahaf
> Sent: woensdag 18 mei 2011 9:40
> To: dev_at_subversion.apache.org
> Subject: Re: enhancements for error reporting
> I don't understand why we would need to change the libraries when the
> cmdline client can already figure out --- using the same libraries ---
> what advice to print.
>
> Stefan KŁng wrote on Wed, May 18, 2011 at 07:32:09 +0200:
> > On Tue, May 17, 2011 at 22:55, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> > > On 05/17/2011 08:54 PM, Stefan KŁng wrote:
> > >> Hi,
> > >>
> > >> Currently the svn command line client prints out (sometimes, if it's
> > >> possible) some helpful messages telling the user what to do, e.g., run a
> > >> cleanup or try an update.
> > >>
> > >> The problem I have in TSVN is that in most situations, the error code that's
> > >> returned is not specific enough. For example, the error code
> > >> SVN_ERR_CLIENT_NOT_READY_TO_MERGE is not just used if the working copy is
> > >> out of date and needs updating, but also if the revision of the working copy
> > >> can not be determined, if a subtree is switched, the wc has local
> > >> modifications or if it's not 'ancestrally related'.
> > >> So in TSVN I can not use the error code to offer the user to just run an
> > >> update and retry the merge, or run cleanup and retry whatever command failed
> > >> because of that.
> > >>
> > >> Could the error baton be extended to contain "action codes" that indicate
> > >> what action(s) need to be done to (probably) resolve the error?
> > >
> > > Rather than creating yet another piece of error metadata with this "action
> > > code", would it suffice for the libs to just use unique error code for these
> > > various situations?
> >
> > That would be ok too of course. Not quite as easy to handle in
> > clients, but it would work.
> > Just make sure the error code itself indicates the action, otherwise I
> > have to search through the whole sourcecode and find out whether
> > there's a possible action to execute for the error.
> >
> > Stefan
> >
> > --
> > † † †† ___
> > † oo† // \\† † † "De Chelonian Mobile"
> > †(_,\/ \_/ \† †† TortoiseSVN
> > †† \ \_/_\_/>† † The coolest Interface to (Sub)Version Control
> > †† /_/†† \_\† †† http://tortoisesvn.net
Received on 2011-05-18 10:14:28 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.