[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1103838 - in /subversion/trunk/subversion/bindings/javahl/native: Prompter.cpp Prompter.h

From: Mark Phippard <markphip_at_gmail.com>
Date: Mon, 16 May 2011 15:06:39 -0400

On Mon, May 16, 2011 at 2:50 PM, <markphip_at_apache.org> wrote:
> Author: markphip
> Date: Mon May 16 18:50:40 2011
> New Revision: 1103838
> URL: http://svn.apache.org/viewvc?rev=1103838&view=rev
> Log:
> JavaHL: Fixed JNI code to look for the new UserPasswordCallback class
> in place of the old PromptUserPasswordN classes.  Also removed/updated
> code comments that referenced the old class.
> Our test suite does not exercise this code unless you run the JavaHL
> tests against https:// repository (which no one does).
> [ in subversion/bindings/javahl/ ]
> * native/Prompter.cpp
>  Replaced references to PromptUserPasswordN with UserPasswordCallback.
>  Also removed and updated stale comments.
> * native/Prompter.h
>  Removed stale comments.


I did a simple audit of the JavaHL C++ code after this. Basically I
grepped for:


These are the only two remaining suspicious items. Could you take a look?

Revision.cpp (line 161):

  JNIEnv *env = JNIUtil::getEnv();
  jclass clazz = env->FindClass(JAVA_PACKAGE "/Revision");
  if (JNIUtil::isJavaExceptionThrown())
    return NULL;

And SVNRepos.cpp (line 638):

  JNIEnv *env = JNIUtil::getEnv();
  jclass clazz = env->FindClass(JAVA_PACKAGE"/Lock");
  if (JNIUtil::isJavaExceptionThrown())
    return NULL;

In both cases, those items are now in the "types" package. Attaching
a patch to change those.

Mark Phippard

Received on 2011-05-16 21:07:09 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.