Re: svn commit: r1094150 - in /subversion/trunk/subversion/libsvn_fs_fs: caching.c fs.h fs_fs.c fs_fs.h tree.c

On 14.05.2011 03:45, Daniel Shahaf wrote:
> stefan2_at_apache.org wrote on Sun, Apr 17, 2011 at 14:48:34 -0000:
>> +static svn_error_t *
>> +init_txn_callbacks(svn_cache__t **cache,
>> + apr_pool_t *pool)
>> +{
> ...
>> @@ -386,10 +426,17 @@ svn_fs_fs__initialize_txn_caches(svn_fs_
>> pool));
>>
>> /* reset the transaction-specific cache if the pool gets cleaned up. */
>> - apr_pool_cleanup_register(pool,
>> -&(ffd->txn_dir_cache),
>> - remove_txn_cache,
>> - apr_pool_cleanup_null);
>> + init_txn_callbacks(&(ffd->txn_dir_cache), pool);
> Error leak.
Thanks for the feedback.
In r1103413, I decided that init_txn_callbacks
should simply return void.

-- Stefan^2.
Received on 2011-05-15 18:07:50 CEST