Re: svn commit: r1103177 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

On Sat, May 14, 2011 at 14:19, <hwright_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Sat May 14 18:19:11 2011
> @@ -2466,10 +2466,18 @@ run_final_query(void *baton,
>                 svn_wc__db_wcroot_t *wcroot,
>                 apr_pool_t *scratch_pool)
>  {
> -  int *finalize_idx = baton;
> +  int *final_queries = baton;
> +  int *query_idx = final_queries;

Seems that 'final_queries' is not needed.

>...
> +  struct set_changelist_baton_t scb = { new_changelist, changelist_filter,
> +                                        depth };
> +  int final_queries[] = { STMT_DROP_CHANGELIST_LIST, STMT_DROP_TARGETS_LIST,
> +                          -1 };

It seems that it would be cleaner to just put the 'DROP TABLE
targets_list' into the STMT_DROP_CHANGELIST_LIST (maybe rename the
latter to something like STMT_FINALIZE_CHANGELIST). Then you could rip
out all this multiple statement stuff. I think one STMT would be
cleaner than all this code to support multiple.

>...

Cheers,
-g
Received on 2011-05-14 21:30:22 CEST