[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1101091 - /subversion/trunk/subversion/libsvn_subr/cache-membuffer.c

From: Stefan Fuhrmann <eqfox_at_web.de>
Date: Tue, 10 May 2011 21:50:51 +0200

On 10.05.2011 11:14, Branko Čibej wrote:
> On 10.05.2011 10:34, Stefan Fuhrmann wrote:
>> On 09.05.2011 18:43, Philip Martin wrote:
>>> stefan2_at_apache.org writes:
>>>
>>>> Author: stefan2
>>>> Date: Mon May 9 16:28:16 2011
>>>> New Revision: 1101091
>>>> (svn_cache__membuffer_cache_create): formatting fixes; add
>>>> missing cast
>>>> - c = apr_palloc(pool, segment_count * sizeof(*c));
>>>> + c = (svn_membuffer_t *)apr_palloc(pool, segment_count * sizeof(*c));
>>> Why is that cast necessary?
>>>
>> The Microsoft compiler issued a warning here and
>> the explicit cast silences it. Maybe, it's a C99 thing?
> Can't be, no Microsoft compiler has ever pretended to implement C99 ...
> besides, the rules for void* did not change between C90 and C99.
So, I found out what happened: The *IDE* (editor) complained
about the assignment and thus I "fixed" it without checking the
compiler log.

The compiler is happy without the cast and r1101616.

-- Stefan^2.
Received on 2011-05-10 21:51:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.