[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1100704 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Mon, 09 May 2011 16:57:20 +0100

Julian Foad <julian.foad_at_wandisco.com> writes:

> Alternatively... I'd like to change all our uses of apr_int64_t for
> (wc_id, repos_id, op_depth) to plain "int". I think that would be
> better because it would only occupy one syllable of thought-space rather
> than eight syllables. And I believe there's no functional or
> programmatic reason or benefit for having these three types be int64_t.

> To do that, I would need to introduce an additional type letter into the
> "bindf" format, because some parameters will still need to be int64_t

I think that is a bad idea unless there is some way to automatically
catch a mismatch between an integer argument and multiple integer format
letters. We regularly made mistakes in svn_error_createf before we
added the gcc stuff to do printf checking.

I don't know if we can use that for bindf as I'm not sure if it would
handle our "t" that consumes two arguments, but until we have some sort
of automatic checking the fewer format letters the better. While we
rely on manual checking the rule "all bound integers are 64bit" is
easier to verify.

Received on 2011-05-09 17:57:53 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.