On Fri, May 6, 2011 at 2:28 PM, Paul Burba <ptburba_at_gmail.com> wrote:
> On Fri, May 6, 2011 at 12:31 PM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
>> On 05/06/2011 12:22 PM, Paul Burba wrote:
>>> On Thu, Mar 31, 2011 at 2:06 PM, Bert Huijben <bert_at_qqmail.nl> wrote:
>>>> Svn cleanup was only designed for recovering from a locked workingcopy.
>>>> So yes, this is really expected behavior.
>>>>
>>>> You should only run cleanup when it's necessary and when you are sure
>>>> no other commands are operating on your wc. See svn help cleanup and
>>>> the subversion book.
>>>
>>> So as to the original problem that r1087131 fixed: issue #3835 "'cd
>>> A/B; svn cleanup' errors out, wanting 'svn cleanup /path/to/wc/root'
>>> instead". This is currently blocking 1.7.0. Is there any objection
>>> to fixing it as Bert suggested at the start of this thread, by simply
>>> providing an improved error message telling where the cleanup must be
>>> rooted to succeed (or maybe just a recommendation to run cleanup at
>>> the root of the wc)?
>>
>> No objection here. I'd say to go ahead and note the correct target
>> directory in the error response. See svn_wc_get_wc_root().
>
> That's what I'll do then..."That" being something like this:
>
> Old:
>
> C:\SVN\src-trunk\svn-win32-Debug-binaries\wc1>svn cleanup trunk
> svn: E155004: Working copy
> 'C:\SVN\src-trunk\svn-win32-Debug-binaries\wc1\trunk' locked.
> svn: E155004: 'C:\SVN\src-trunk\svn-win32-Debug-binaries\wc1' is
> already locked.
> svn: run 'svn cleanup' to remove locks (type 'svn help cleanup' for details)
>
> New:
>
> C:\SVN\src-trunk\svn-win32-Debug-binaries\wc1>svn cleanup trunk
> svn: E155004: Try cleanup from root of working copy
> 'C:/SVN/src-trunk/svn-win32-Debug-binaries/wc1'
> svn: E155004: Working copy
> 'C:\SVN\src-trunk\svn-win32-Debug-binaries\wc1\trunk' locked.
> svn: E155004: 'C:\SVN\src-trunk\svn-win32-Debug-binaries\wc1' is
> already locked.
> svn: run 'svn cleanup' to remove locks (type 'svn help cleanup' for details)
Done, r1100321.
> Paul
>
>> --
>> C. Michael Pilato <cmpilato_at_collab.net>
>> CollabNet <> www.collab.net <> Distributed Development On Demand
>>
>>
>
Received on 2011-05-06 20:45:00 CEST