Re: svn commit: r1099958 - /subversion/trunk/subversion/libsvn_ra_neon/commit.c

On 05/05/2011 05:54 PM, Greg Stein wrote:
> On Thu, May 5, 2011 at 16:26, <cmpilato_at_apache.org> wrote:
>> ...
>> +++ subversion/trunk/subversion/libsvn_ra_neon/commit.c Thu May 5 20:26:36 2011
>> ...
>> +static svn_error_t *copy_resource(svn_ra_neon__session_t *ras,
>> + const char *copyfrom_path,
>> + svn_revnum_t copyfrom_revision,
>> + const char *copy_dst_url,
>> + svn_boolean_t is_dir,
>> + apr_pool_t *scratch_pool)
>> +{
>> ...
>> + /* Have neon do the COPY. */
>> + SVN_ERR(svn_ra_neon__copy(ras, 1 /* overwrite */,
>> + is_dir ? SVN_RA_NEON__DEPTH_INFINITE
>> + : SVN_RA_NEON__DEPTH_ZERO,
>> + copy_src_url, copy_dst_url, scratch_pool));
>
> If the depth is ignored for files, then why not just always pass
> INFINITE and be done with it?

That was on my "double-check this later" list. :-) I'm still working in
this code, and first-pass was intended to make no logical changes. But your
question validates my own line of thought here, so thanks!

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand