[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

AW: svn commit: r1099657 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c wc_db.h

From: Markus Schaber <m.schaber_at_3s-software.com>
Date: Fri, 6 May 2011 11:44:47 +0200

Hi, Hyrum,

> Von: Hyrum K Wright [mailto:hyrum_at_hyrumwright.org]

> > Our code currently relies on the notifications being "lossless", as
> > were told on #svn-dev that this is the way how to find out about
> > property changes done by svn operations (update, revert), as
> > is not set any more.
> >
> > If notifications get unreliable, then we have to maintain our own
> > shadow tree of the working copy tree, and compare the properties of
> > all files after each operation, just to find out which nodes we have
> re-read.
> Even if this change is left in, as the API consumer, you don't have
> anything to worry about. Cancellation is effected by calling a
> provided callback to see if the operation should cancel, and as the
> provider of that function, you can either not provide it (disallowing
> possibility of cancellation) or not cancel within it.

Our current implementation forwards those notifications to the caller
(the one triggering the actual operation, e. g. a menu entry), allowing
them to intercept those notifications when they call high level
subversion functions through our API. Up to now, we wanted to allow
those callers to cancel long running operations, for example when the
user presses an Abort button, or by applying a timeout or whatever
criteria our callers want to apply.

The mentioned change will forbid me to accept cancels for long running
operations, as I rely on those notifications. Maybe I will be able to
stop forwarding the notifications to our caller, but I won't be able to
pass the cancellation request down to SharpSVN/LibSVN.

My understanding of semantics of cancellation was to cancel the
operation, not to cancel pending notifications for already finished
actions of the operation.

Best regards,

Markus Schaber

We software Automation.

3S-Smart Software Solutions GmbH
Markus Schaber | Developer
Memminger Str. 151 | 87439 Kempten | Germany | Tel. +49-831-54031-0 |
Fax +49-831-54031-50

Email: m.schaber@3s-software.com | Web: http://www.3s-software.com
CoDeSys internet forum: http://forum.3s-software.com
Download CoDeSys sample projects:

Managing Directors: Dipl.Inf. Dieter Hess, Dipl.Inf. Manfred Werner |
Trade register: Kempten HRB 6186 | Tax ID No.: DE 167014915
Received on 2011-05-06 11:45:21 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.