[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1099657 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c wc_db.h

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 5 May 2011 11:28:22 +0200

On Thu, May 05, 2011 at 02:20:09AM -0400, Greg Stein wrote:
> Ideally, the notification
> process is fast, but somebody left a question of putting a cancel func
> in that processing, and it sounded reasonable. We just don't know what
> that callback is doing.

Why do we want to allow callbacks to do anything they want?
What if the callback tries to do something that will result in a deadlock?

Can't we document what the callback is allowed to do and what it isn't
allowed to do? Even if descriptions end up being vague, like "this callback
should complete fast"?

Thinking about it I'm actually surprised that we're not doing this.
I wonder how many times consumers of our APIs have been asking themselves
questions about what they're allowed to do while implementing callbacks.
I suppose the only place to find answers to such questions right now is
our own code.
Received on 2011-05-05 11:29:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.