[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1099218 - /subversion/trunk/subversion/libsvn_wc/info.c

From: Hyrum K Wright <hyrum_at_hyrumwright.org>
Date: Tue, 3 May 2011 15:30:44 -0500

On Tue, May 3, 2011 at 3:25 PM, Greg Stein <gstein_at_gmail.com> wrote:
> On Tue, May 3, 2011 at 16:03,  <hwright_at_apache.org> wrote:
>>...
>> +++ subversion/trunk/subversion/libsvn_wc/info.c Tue May  3 20:03:13 2011
>> @@ -172,11 +172,12 @@ build_info_for_entry(svn_info2_t **info,
>>   /* A default */
>>   tmpinfo->size = SVN_INVALID_FILESIZE;
>>
>> -  SVN_ERR(svn_wc__node_get_schedule(&tmpinfo->wc_info->schedule, NULL,
>> -                                    wc_ctx, local_abspath, scratch_pool));
>> +  SVN_ERR(svn_wc__internal_node_get_schedule(&tmpinfo->wc_info->schedule, NULL,
>> +                                             wc_ctx->db, local_abspath,
>> +                                             scratch_pool));
>
> Why is wc_ctx being passed around these module-private functions?
> Shouldn't you pop that open in the semi-public function, and pass
> around DB?
>
> Hm. Maybe because there are still references to svn_wc__node_* functions?

Exactly. And the above is one of the steps in removing those
references (and thus the need to pass around wc_ctx). All this code
came in from libsvn_client, and is slowly morphing into a native
libsvn_wc citizen.

-Hyrum
Received on 2011-05-03 22:31:13 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.