[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1096619 - in /subversion/trunk/subversion/libsvn_wc: translate.c translate.h workqueue.c

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 26 Apr 2011 01:29:26 -0400

On Mon, Apr 25, 2011 at 20:56, Hyrum K Wright <hyrum_at_hyrumwright.org> wrote:
> On Mon, Apr 25, 2011 at 5:59 PM, Greg Stein <gstein_at_gmail.com> wrote:
>>> Instead, we've extended a skel so that the code can determine which
>>> version you're using (eg. a new, optional element at the end). Or
>>> we've chosen two different OP names ("foo" and "foo-2") that dispatch
>>> to different skel parsers and call a common function.
> Thanks for the background.  Unfortunately, I don't know that this
> policy is documented anywhere (certainly not in workqueue.h).

Yup. I'm crap for documentation. Dunno where to put this. Maybe a
comment block where OP_* is defined? Something in the 'notes'
directory? ... just not sure what would be best, such that future devs
making changes, similar to the above, would find it.

> I've re-added placeholder values in r1096641, so that the parse doesn't choke.

Cool. Will look...

Received on 2011-04-26 07:29:59 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.