Re: externals not respected until committed

On Mon, Apr 25, 2011 at 10:03, Stefan Küng <tortoisesvn_at_gmail.com> wrote:
> On Mon, Apr 25, 2011 at 09:21, Stefan Küng <tortoisesvn_at_gmail.com> wrote:
>> On 24.04.2011 13:09, Bert Huijben wrote:
>>
>>>> For 1.7 there will probably be a flag which will allow you to shoot
>>>
>>> yourself
>>>>
>>>> in the foot by processing local-only versions of svn:externals
>>>> properties.
>>>> Which resolves the common "How can I test svn:externals?" and "Can I have
>>>> my
>>>> own externals to override the repository ones?" (mini-viewspec)
>>>> scenarios.
>>>> (Suggestions for the '--argument-name' are welcome. --force is already
>>>> taken)
>>>
>>> Since r1096306 available at the libsvn_client level.
>>
>> Thanks!
>> That really helps.
>
> Bad news: this doesn't seem to work. I've checked that I pass 'true'
> to svn_client_update4 for the apply_local_external_modifications
> parameter, but the local mods to svn:externals are not used.

My guess the bug is here:
libsvn_client\externals.c, line 1481:

if (! apr_hash_get(externals_new, local_abspath, APR_HASH_KEY_STRING))

should really be

if (apr_hash_get(externals_new, local_abspath, APR_HASH_KEY_STRING))

At least it works for me that way.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net