[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1095507 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/externals.c libsvn_client/prop_commands.c libsvn_wc/props.c libsvn_wc/wc_db.c libsvn_wc/wc_db.h

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 20 Apr 2011 17:34:50 -0400

On Wed, Apr 20, 2011 at 16:33, <rhuijben_at_apache.org> wrote:
> Author: rhuijben
> Date: Wed Apr 20 20:33:18 2011
> New Revision: 1095507
> URL: http://svn.apache.org/viewvc?rev=1095507&view=rev
> Log:
> Make the streamy property read code differentiate between pristine and BASE
> properties. The standard property functions in libsvn_client want to look at
> pristine properties, but usually not explicitly at op_depth 0.
> * In WC-NG pristine properties are unmodified properties.
> * And BASE properties are the op_depth 0 properties.
> Virtually no libsvn_client code should look at BASE directly.
> (In the old WC-1.0 world we would call that the revert base)

Right. So why provide a way for the client to do this? I don't see any
of these calls where base_props=TRUE, so why add the parameter?

(and "for the future" doesn't sit well with me)

Do you have an upcoming change where the client needs to read the BASE props?


Received on 2011-04-20 23:35:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.