Re: svn commit: r1095130 - in /subversion/trunk/subversion: libsvn_client/client.h libsvn_client/externals.c libsvn_client/switch.c libsvn_client/update.c libsvn_wc/adm_crawler.c tests/cmdline/externals_tests.py

On 04/20/2011 01:32 PM, Stefan Sperling wrote:
> For the record, Bert and I discussed this on IRC today.
>
> The conclusion is that this feature will be revived as it was implemented,
> with the addition of a new flag to svn update that allows users to enable
> external definitions on locally added directories. Without this flag,
> external definitions on locally added directories will be ignored.
>
> There is a performance overhead involved in crawling the DB for external
> definitions. Bert's opinion is that adding this overhead to every update
> operation is not acceptable. I don't think that is a big problem.
> But the command line switch will make both of us happy.
>
> This way, users can test their externals definitions locally before
> committing them, which is the goal of issue #2267. But normal updates
> will not have to endure additional overhead.

This just sounds like a truly odd thing to hook to a command-line option.
That said, I confess my ignorance of the details of the issue. We already
have to crawl for external definitions as part of 'svn update', don't we?
Isn't that what the external_func/external_baton pair passed to
svn_wc_crawl_revisions5() is for?

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand