[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] to help benchmark.py run on windows

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 19 Apr 2011 18:06:32 -0400

On Tue, Apr 19, 2011 at 17:37, Alan Wood <Alan.Wood_at_clear.net.nz> wrote:
> On 19 Apr 2011 at 13:07, Greg Stein wrote:
>> >
>> > On Windows, the path returned by mkdtemp() is something like
>> >
>> >  C:\users\billga~1\appdata\local\temp\tmpfoobar
>> >
>> > with no leading slash, so an extra slash makes the URL valid.
>> >
>> > The directory path could even have spaces in it, if the user wishes.
>> > For a geeky script like this, we don't have to be paranoid.
>> I reviewed that portion of Alan's patch and omitted, for the reasons
>> Neels stated, but I also think the following is valid:
>> file://C:/users/blah/blah/repos
> Not valid: the code goes off looking for a network machine called 'C:'  and comes back some
> time later with an error.
>  IIRC the text between the 2nd and 3rd slash is a machine name.


>> Thus, I left out the introduction of a slash. Are you sure there is
>> supposed to be a third slash in there? My impression is that the
>> "third slash" is a result of the leading slash of an absolute path in
>> Unix. But for Windows, you start with the drive letter (tho you could
>> get a slash if you use a remote path).
> I suppose mkdtemp could come back with '\\servername\temp\blah\'. That would make a real
> mess. That may happen is the current drive was invalid, but so much else would fail that I
> can't really get worried about it.

hehe... yeah.

I just found this:

While Wikipedia is not authoritative, I see no reason to distrust it.
I'll go ahead and apply your original suggestion. Thanks!

Received on 2011-04-20 00:06:59 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.