On Mon, 2011-04-18 at 19:47 -0400, Greg Stein wrote:
> Applied in r1094816.
>
> On Mon, Apr 18, 2011 at 18:44, Greg Stein <gstein_at_gmail.com> wrote:
> > On Mon, Apr 18, 2011 at 07:04, Alan Wood <Alan.Wood_at_clear.net.nz> wrote:
> >> Hi devs,
> >> I have just been looking at running the benchmarks and have got to the stage where I can
> >> run it on windows.
> >>
> >> This attached patch fixes three issues with the script:
> >> 1) use of file:// when I'm sure that file:/// is correct from previous discussions on this list
This particular change is not necessary -- code extract with
annotations:
base = tempfile.mkdtemp() # base == '/tmp/dir123'
repos = j(base, 'repos') # repos == '/tmp/dir123/repos'
file_url = 'file://%s' % repos # file_url == 'file://' + '/tmp/...'
With your change, file_url becomes file:////tmp/..., which is still
valid, but nonsense :) (BTW, the script would not have worked if there
had been only two slashes.)
Thanks for your patch, Alan!
~Neels
> >> 2) make sure no \ end up is repos url file://
> >> 3) at error handler to rmtree to handle the windows read-only files.
> >>
> >> I have removed the "which svn" command, not sure how to do this so it is only removed on
> >> windows as I'm not really a python person.
> >> I hope this is useful.
> >> I haven't provided a log message as I don't really think it can be applied without a bit of
> >> editing.
> >
> > Yes, it will certainly be useful. Thanks!
> >
> > I'll fold your changes into the scripts. It is handy because I don't
> > have a Windows machine for testing. Please go ahead and continue
> > sending your patches to the list!
> >
> > (or if you'd like, we can offer you direct commit access to the
> > suite1/ directory)
> >
> > Cheers,
> > -g
> >
Received on 2011-04-19 15:32:55 CEST