[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Changelists on directories

From: Hyrum K Wright <hyrum_at_hyrumwright.org>
Date: Mon, 18 Apr 2011 13:37:54 -0500

On Mon, Apr 18, 2011 at 1:15 PM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> On 04/18/2011 02:05 PM, Hyrum K Wright wrote:
>> The issue is a bit sparse on details, so before I go changing this
>> behavior, I'd like to have a bit more information.  Other than simple
>> storage mechanisms, what other considerations came into the decision
>> not to allow changelists on directories?  Was there some bikeshed
>> which just never got painted the right color?
>
> First thing that comes to mind is pretty straightforward:
>
>   $ svn cl my-changelist dir
>   $ svn pset my-prop my-value dir
>   $ cat "New line of text." >> dir/file
>   $ svn ci --cl my-changelist
>
> Do we, or do we not, commit dir/file?

My gut reaction would be changelists should act like a built-in list
of targets, similar to using the '--targets' option. Putting
something in a changelist should simply be shorthand for specifying it
on the command line. I don't think there is any ambiguity about:
  $ svn ci dir

nor:
  $ echo 'dir' > targets
  $ svn ci --targets targets

But this could just be my simplistic, cli-centric, anglophile brain
talking here. If there is a simple solution, let's do it. If we need
to make a relatively simple decision, let'd make it. If we need to
debate it for a while (which I'm not opposed to, if needed), let's
table it and I'll work on more important stuff.

-Hyrum
Received on 2011-04-18 20:38:28 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.