[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1092752 - /subversion/trunk/subversion/libsvn_wc/deprecated.c

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 15 Apr 2011 14:24:48 -0400

Don't you actually want that error conversion?
On Apr 15, 2011 12:00 PM, <julianfoad_at_apache.org> wrote:
> Author: julianfoad
> Date: Fri Apr 15 15:59:48 2011
> New Revision: 1092752
>
> URL: http://svn.apache.org/viewvc?rev=1092752&view=rev
> Log:
> * subversion/libsvn_wc/deprecated.c
> (svn_wc_set_changelist): Revert a change made accidentally in r1092751.
>
> Modified:
> subversion/trunk/subversion/libsvn_wc/deprecated.c
>
> Modified: subversion/trunk/subversion/libsvn_wc/deprecated.c
> URL:
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/deprecated.c?rev=1092752&r1=1092751&r2=1092752&view=diff
>
==============================================================================
> --- subversion/trunk/subversion/libsvn_wc/deprecated.c (original)
> +++ subversion/trunk/subversion/libsvn_wc/deprecated.c Fri Apr 15 15:59:48
2011
> @@ -1194,23 +1194,15 @@ svn_wc_set_changelist(const char *path,
> {
> const char *local_abspath;
> svn_wc_context_t *wc_ctx;
> - svn_error_t *err;
>
> SVN_ERR(svn_dirent_get_absolute(&local_abspath, path, pool));
> SVN_ERR(svn_wc__context_create_with_db(&wc_ctx, NULL /* config */,
> svn_wc__adm_get_db(adm_access),
> pool));
>
> - /* If the node is a directory, the old function always returned the
error
> - * SVN_ERR_CLIENT_IS_DIRECTORY (despite this not being a client layer
> - * function and despite its doc string saying it would return
> - * SVN_ERR_UNSUPPORTED_FEATURE). */
> - err = svn_wc_set_changelist2(wc_ctx, local_abspath, changelist, NULL,
> - cancel_func, cancel_baton, notify_func,
> - notify_baton, pool);
> - if (err && err->apr_err == SVN_ERR_WC_NOT_FILE)
> - err->apr_err = SVN_ERR_CLIENT_IS_DIRECTORY;
> - SVN_ERR(err);
> + SVN_ERR(svn_wc_set_changelist2(wc_ctx, local_abspath, changelist, NULL,
> + cancel_func, cancel_baton, notify_func,
> + notify_baton, pool));
>
> return svn_error_return(svn_wc_context_destroy(wc_ctx));
> }
>
>
Received on 2011-04-15 20:25:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.