[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1091928 - in /subversion/trunk/subversion: libsvn_client/commit.c tests/cmdline/commit_tests.py

From: Hyrum K Wright <hyrum_at_hyrumwright.org>
Date: Thu, 14 Apr 2011 10:47:20 -0500

On Wed, Apr 13, 2011 at 4:47 PM, <rhuijben_at_apache.org> wrote:
> Author: rhuijben
> Date: Wed Apr 13 21:47:24 2011
> New Revision: 1091928
> URL: http://svn.apache.org/viewvc?rev=1091928&view=rev
> Log:
> Fix issue #2381: "Cannot commit multiple WC paths which lack a common parent
> directory" by making the commit processor determine which locks it needs in
> which working copy.

I've not looked at the code, but am just wondering about a theoretical
point here. Could the approach fall victim to the same cause as issue
#3242? Specifically, if all the commits are done in the same editor
drive, and that editor drive is rooted somewhere outside of the
readable or writable location for the user doing the commit, would we
get authz denials?

I can just envision the scenario where users try to commit multiple
working copies rooted somewhere they can't write to, and it ends up in
all kinds of confusion. (Just another reason to introduce the eXecute
bit in our authz paradigm...)

Received on 2011-04-14 17:47:54 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.