Re: svn commit: r1091495 - in /subversion/trunk/subversion/libsvn_wc: wc.h workqueue.c

On Tue, Apr 12, 2011 at 13:34, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> On 04/12/2011 01:08 PM, Philip Martin wrote:
>> Greg Stein <gstein_at_gmail.com> writes:
>>
>>>> + * If the text is unmodified and a write-lock is held this function
>>>> + * will repair "broken" timestamps and filesizes.
>>>
>>> I don't understand what is repaired. The database, or the file. If the file,
>>> then how do we repair its filesize?
>>>
>>> This notion of "repair" is equally fuzzy in the later portions of this
>>> commit.
>>
>> "Timestamp repair" is the term that has been used since it was introduced
>> in 1.2.  I'll look at writing it down somewhere.

Yeah... I've generally glossed over it when running into it, and then
called it "record fileinfo" when writing wc_db code. The latter is
much clearer, I believe.

>
> See r1091512.

Thanks. It is much clearer now!

I'd still prefer to stick to "record fileinfo" when possible, though.
There is no ambiguity about *what* is being "repaired" (ie. it could
have been use_commit_times, so we would *set* the file's timestamp...
I just didn't know).

Cheers,
-g
Received on 2011-04-12 20:50:54 CEST