[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1091262 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

From: Mark Phippard <markphip_at_gmail.com>
Date: Tue, 12 Apr 2011 09:38:21 -0400

On Tue, Apr 12, 2011 at 9:27 AM, Hyrum K Wright <hyrum_at_hyrumwright.org> wrote:

>> Not sure. Maybe we can work through some ideas. But "we have no other
>> choice" is not a good enough reason to keep this. That is an even worse
>> slope to slide down. Doing things simply because they are "convenient".
> The general consensus seems to be to revert the whole lot of these
> changes, and I'll bow to those wishes and comply.

I do not think you should just back the changes right out immediately.
 Greg is not the only vote or voice in the project. Just because he
has come out with a strong opinion on the matter does not mean he is
right or it is the only answer.

I am not saying Greg is wrong here either, I do not really know. You
seem like you have made some fairly reasonable counter points to his
concerns about SQL injection. It seems worthy of a broader discussion
before changes are made.

Greg has raised some objections. It seems like you have responded to
them. I would like to see the discussion continue.

Mark Phippard
Received on 2011-04-12 15:38:53 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.