[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1091262 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Tue, 12 Apr 2011 11:22:54 +0200

> -----Original Message-----
> From: Greg Stein [mailto:gstein_at_gmail.com]
> Sent: dinsdag 12 april 2011 4:41
> To: dev_at_subversion.apache.org
> Subject: Re: svn commit: r1091262 -
> /subversion/trunk/subversion/libsvn_wc/wc_db.c
> Woah. When did svn_sqlite__prepare arrive?
> I'm basically -1 on that.
> The whole idea behind static statements was to avoid SQL injection
> Allowing the *code* to construct statements opens us up.

+1 on that '-1'

You are looking at changelists as a way to learn how to move operations into
wc_db properly, but just like that temp table for notifications I don't see
this as the way to go forward.

I really don't see why users want to add thousands of nodes to changelists
while we still don't support changelists on directories. And if it is just a
handful of nodes the old code worked fine.

Once we start building svn stash, etc. things will be different... But that
is way out of scope for 1.7.

I think this time can be spend in a better way by documenting how
changelists should behave on directories and then enabling that. That would
be a truly useful feature.
(And it should be a lot easier than in 1.5 when we didn't have an op_root

Received on 2011-04-12 11:23:32 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.