[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix for issue 3787

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 7 Apr 2011 09:57:53 +0300

Noorul Islam K M wrote on Thu, Apr 07, 2011 at 10:17:49 +0530:
> Index: subversion/tests/cmdline/depth_tests.py
> ===================================================================
> --- subversion/tests/cmdline/depth_tests.py (revision 1089373)
> +++ subversion/tests/cmdline/depth_tests.py (working copy)
> @@ -2815,7 +2815,38 @@
> None, None, None, None, None, False,
> '--parents', omega_path)
>
> +@Issue(3787)
> +def info_show_exclude(sbox):
> + "tests 'info -R' on excluded directory"
>

Nit: usually we use the base form of the verb, i.e., s/tests/test/.

> + sbox.build()
> + wc_dir = sbox.wc_dir
> +

You can pass READ_ONLY to sbox.build().

> + A_path = os.path.join(wc_dir, 'A')
> + svntest.main.run_svn(None, 'up', '--set-depth', 'exclude', A_path)
> +
> + expected_info = [{
> + 'Path' : '.',
> + 'Repository Root' : sbox.repo_url,
> + 'Repository UUID' : svntest.actions.get_wc_uuid(wc_dir),
> + }]
> +

get_wc_uuid() is expensive, please call it just once, it will return the
same value each time...

> + expected_info.append({
> + 'Path' : 'A',
> + 'Repository Root' : sbox.repo_url,
> + 'Repository UUID' : svntest.actions.get_wc_uuid(wc_dir),
> + 'Depth' : 'exclude',
> + })
> +
> + expected_info.append({
> + 'Path' : re.escape("iota"),
> + 'Repository Root' : sbox.repo_url,
> + 'Repository UUID' : svntest.actions.get_wc_uuid(wc_dir),
> + })
> +
> + os.chdir(wc_dir)
> + svntest.actions.run_and_verify_info(expected_info, '-R')
> +
> #----------------------------------------------------------------------
> # list all tests here, starting with None:
> test_list = [ None,
> @@ -2862,6 +2893,7 @@
> update_excluded_path_sticky_depths,
> update_depth_empty_root_of_infinite_children,
> sparse_update_with_dash_dash_parents,
> + info_show_exclude,
> ]
Received on 2011-04-07 08:58:37 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.