[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1089257 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc-queries.sql wc_db.c wc_db.h

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Wed, 06 Apr 2011 10:17:51 -0400

On 04/06/2011 08:58 AM, Greg Stein wrote:
> Note: beyond the review below, I'm registering a general concern
> around this notion of "hey! let's drop off this data into some global
> variables^W^Woh, I mean the wc state database... and then some time
> later, we'll perform some operation around them".
> This is *so* ripe for danger, I'm depressed.
> Honestly. This "temporary table" is just another name for "global
> variable". "Results are collected in a table". Really? REALLY? How is
> that different from a global?

I don't think anyone would claim that this is different (as an approach) to
a global variable. IIUC, it's for the express goal of avoiding having to
keep potentially large amounts of in-memory state that this approach was taken.

I'd love to see a better suggestion, ideally one that avoids the glut of new
queries and bifurcation of the "depth" concept into 3 or 4 different handler
functions such as what I recall was the case for what should have been a
relatively simple 'proplist' operation. (Maybe that's been cleaned up
recently, or maybe I misunderstood the code in the first place -- I can't
say for sure.)

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2011-04-06 16:18:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.