Re: svn commit: r1087015 - in /subversion/trunk/subversion: include/ libsvn_client/ svn/ tests/cmdline/ tests/cmdline/getopt_tests_data/ tests/cmdline/svntest/

On 03/31/2011 05:18 AM, Daniel Shahaf wrote:
> cmpilato_at_apache.org wrote on Wed, Mar 30, 2011 at 16:54:02 -0000:

[...]

>> + if (! (yc_path && SVN_IS_VALID_REVNUM(yc_rev)))
>> + return svn_error_create(SVN_ERR_CLIENT_UNRELATED_RESOURCES,
>> + NULL, NULL);
>
> Perhaps mention SWITCH_REV_URL and TARGET_URL in the error message?

SWITCH_REV_URL and TARGET_URL won't be directly meaningful to the caller, as
neither are inputs to the function. But I should be able to use SWITCH_URL
and LOCAL_ABSPATH.

>> + if (err->apr_err == SVN_ERR_CLIENT_UNRELATED_RESOURCES)
>> + return svn_error_createf(SVN_ERR_CLIENT_UNRELATED_RESOURCES, err,
>> + "Path '%s' does not share common version "
>> + "control ancestry with the requested switch "
>> + "location. Use --ignore-ancestry to disable "
>> + "this check.", target);
>
> You aren't _()'ing the error message.

Doh! That's so easy for me to forget.

Thanks for the review, Daniel. Improvements committed:

   Sending trunk/subversion/libsvn_client/switch.c
   Sending trunk/subversion/svn/switch-cmd.c
   Sending trunk/subversion/tests/cmdline/basic_tests.py
   Transmitting file data ...
   Committed revision 1087302.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand