[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1086936 - /subversion/trunk/subversion/libsvn_subr/cmdline.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 30 Mar 2011 22:12:30 +0200

stsp_at_apache.org wrote on Wed, Mar 30, 2011 at 12:49:39 -0000:
> /* ### Issue #3014: Return a specific error for broken pipes,
> * ### with a single element in the error chain. */
> + if (APR_STATUS_IS_EPIPE(apr_get_os_error()))
> + return svn_error_create(SVN_ERR_IO_PIPE_WRITE_ERROR, NULL, NULL);
> else
> + return svn_error_wrap_apr(apr_get_os_error(), _("Write error"));
> }
> else
> return svn_error_create

You evaluate errno twice. Shouldn't you store it in a temporary variable?
Received on 2011-03-30 22:13:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.