RE: Bug in svnrdump (trunk@1085375) -- malformed dump file with multiple properties
Date: Mon, 28 Mar 2011 13:26:46 +0100
On 25 March 2011 at 19:19, Hyrum K Wright wrote
Sorry, but no cigar :( This probably fixes the assertion found by Hyrum, but doesn't address the original issue. The current test case added to the test suite addresses loading multiple propedits. That's good, but it's not sufficient. The heart of the issue is that a transaction with multiple propedits to a single path is *dumped* incorrectly. So for an original dump representation like this:
--- Node-path: Node-kind: dir Node-action: change Prop-content-length: 42 Content-length: 42 K 3 foo V 3 bar K 3 bar V 3 baz PROPS-END --- The svnrdump output for the same transaction comes out like this: --- Node-path: Node-kind: dir Node-action: change Prop-delta: true Prop-content-length: 26 Content-length: 26 K 3 foo V 3 bar PROPS-END Prop-delta: true Prop-content-length: 26 Content-length: 26 K 3 bar V 3 baz PROPS-END --- Note the second "orphaned" prop-delta. It would be great if svnrdump produced exactly the same output as svnadmin (it'd make the test assertions nice and easy), but from a bit of experimentation (I haven't read the svnadmin code here) I don't believe that it's necessary for the two prop-deltas actually to be merged for the dumpfile to be valid. So if it's easier to repeat the preceding node-path information for each prop-delta then I guess that would be OK, as long as the net result is the same. Thanks, NeilReceived on 2011-03-28 14:26:58 CEST
This is an archived mail posted to the Subversion Dev mailing list.