Re: svn commit: r1081484 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

On Sat, Mar 26, 2011 at 09:51:46AM -0400, Greg Stein wrote:
> > --- subversion/trunk/subversion/libsvn_wc/wc-queries.sql (original)
> > +++ subversion/trunk/subversion/libsvn_wc/wc-queries.sql Mon Mar 14
> 17:24:05 2011
> > @@ -910,6 +910,11 @@ WHERE wc_id = ?1 AND (local_relpath = ?2
> > presence = 'base-deleted')
> > AND file_external IS NULL;
> >
> > +-- STMT_SELECT_NODES_WITH_PROP_MODIFICATIONS
> > +SELECT local_relpath FROM actual_node
> > +WHERE wc_id = ?1 AND (local_relpath = ?2 OR local_relpath LIKE ?3 ESCAPE
> '#')
> > + AND properties IS NOT NULL;
>
> This looks like you're searching for *children* of the target node. Why?

The entire point of this query is that it is recursive.
We want to know if there are any nodes in the working copy with
property modifications.

> > + /* If this query returns a row, the working copy is modified. */
> > + SVN_ERR(svn_sqlite__step(&have_row, stmt));
> > + *is_modified = have_row;
>
> Why use 'have_row' at all? Why not pass is_modified directly?

Sure, r1086192.
Received on 2011-03-28 13:28:48 CEST