[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Property storage / modification in WC-NG

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Thu, 17 Mar 2011 17:29:14 +0000

Mike, Greg,

Is it OK with you if I remove the single-prop-get WC DB APIs, which are
unused? In light of what you're talking about I just want to check this
won't be stepping on your toes.

[[[
Remove unused single-prop-get functions from the WC DB API, because they
were just clutter in the API. The "read all props" and "write all
props" APIs make a sensible interface by themselves and there are no
"write one prop" interfaces at this level.

* subversion/libsvn_wc/wc_db.h,
  subversion/libsvn_wc/wc_db.c
  (svn_wc__db_base_get_prop, svn_wc__db_read_prop): Remove.

* subversion/tests/libsvn_wc/db-test.c
  (validate_node): Remove the testing of svn_wc__db_base_get_prop(). It
    still tests svn_wc__db_base_get_props(). There were no tests for
    svn_wc__db_read_prop().
]]]

- Julian
Received on 2011-03-17 18:29:52 CET

This is an archived mail posted to the Subversion Dev mailing list.