On Mon, Mar 14, 2011 at 06:22:11PM +0100, Bert Huijben wrote:
> It adds an insane amount of conditionals. How are you going to test this and
> maintain it?
> The complexity of sourcecode increases by every conditional.
The testing approach taken by Arwin seems solid enough in my book.
> I don't see the added benefit of having this feature compared to the
> complexity this implementation of this feature adds. There must be simpler
> ways to add this, without slowing down the work that still has to be done on
> the update editor before releasing 1.7.
If that's what's worrying you, then let's postpone it to after 1.7.
That's fine with me. It means that we'll have to write a new diff
that fits on top of the post-1.7 update editor code. But if stability
concerns outweigh this, I can live with that.
> This implementation makes me starting to think about when we have to start
> on WC-NG-NG to remove the complexity added here.
I haven't yet seen any good suggestion for an alternative approach.
Dry run implies carrying out every step made during an update expect
making modifications to the working copy. The suggestion to put dry-run
into a separate editor is even worse because it duplicates at lot more
conditionals (for update logic) in a new place than this patch is adding
to existing places.
If there is a cleaner way to do it, fine. Maybe Arwin would like to learn
about this better approach and try to implement it, for update and for merge.
But is there?
Received on 2011-03-14 18:37:05 CET