[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Add --dry-run flag to "svn update" client command

From: Bert Huijben <bert_at_qqmail.nl>
Date: Mon, 14 Mar 2011 17:55:44 +0100

> -----Original Message-----
> From: Daniel Shahaf [mailto:d.s_at_daniel.shahaf.name]
> Sent: maandag 14 maart 2011 17:34
> To: Kamesh Jayachandran
> Cc: dev_at_subversion.apache.org
> Subject: Re: [PATCH] Add --dry-run flag to "svn update" client command
>
> Kamesh Jayachandran wrote on Fri, Mar 11, 2011 at 18:12:21 +0530:
> > Unless there are no objection I will commit this patch post I
> > receive a r1075802 regression fix(and testcase) from either Daniel
> > Becroft or Arwin.
>
> Hold on, are you suggesting to commit the two thousand, six hundred and
> sixty-three line diff that started this thread?

Please find a cleaner solution to implement this instead of just committing
it.
We have to maintain the update editor and this patch adds so many if-s that
it will be impossible to do that work.

(reply to earlier mail in this thread)
The merge infrastructure also needs cleanup work and eventually that will
happen, but that is no excuse to obfuscate other parts of our code.

        Bert
Received on 2011-03-14 17:56:18 CET

This is an archived mail posted to the Subversion Dev mailing list.