[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: wc_db performance

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Mon, 14 Mar 2011 10:53:48 -0400

> On 12.03.2011 13:47, Stefan Sperling wrote:
>> For others who want to jump in and help, here is a list of places
>> where the node walker is still being used. I'm not sure if we can
>> eliminate it everywhere before release, but each of these should
>> be looked at to see whether we can use an alternative approach to
>> increase performance:
>>
>> subversion/libsvn_client/changelist.c
>> subversion/libsvn_client/commit_util.c
>> subversion/libsvn_client/info.c
>> subversion/libsvn_client/merge.c
>> subversion/libsvn_client/mergeinfo.c
>> subversion/libsvn_client/prop_commands.c
>> (This should be propget and propset. Proplist is already using
>> queries involving temporary tables. Rewriting propget on top
>> of the proplist code would be easy. Propset needs more work.)
>> subversion/libsvn_client/ra.c
>> subversion/libsvn_wc/update_editor.c

I want to jump in and help. But (as is common for me, it seems) the first
place I go to jump in stirs up a question. What is the motif we seek to
apply where we need have per-path notification events that need to happen?
For example, I'm familiar with the changelist code, so I started looking at
making this conversion there. But we do per-path notification in that code.
 How do we approach this? Do we query old state, make the change, query new
state, diff the states and notify on the diffs? That seems ... wrong. Is
there any pattern established upon which I can model these changes?

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2011-03-14 15:54:23 CET

This is an archived mail posted to the Subversion Dev mailing list.